gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

Pass all additional auth to builder

Open Edward13ruf opened this issue 2 years ago • 2 comments

Description

Adds the ability for Gitpod to pass all additional authenticated through to the builder. Right now the additional auth is only passing through some user defined auth which neglects some of the additional auth found in the docker pull secrets. In order for the builder to eventually proxy and mirror upstream registries it needs to know about both the user defined credentials, and the system defined credentials.

This also makes sure that only the auth needed to actually pull the base image is passed through.

Summary generated by Copilot

🤖 Generated by Copilot at a39718e

This pull request adds support for all auth to be passed through to the builder

Related Issue(s)

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • [ ] /werft with-werft Run the build with werft instead of GHA
  • [ ] leeway-no-cache
  • [ ] /werft no-test Run Leeway with --dont-test
Publish
  • [ ] /werft publish-to-npm
  • [ ] /werft publish-to-jb-marketplace
Installer
  • [ ] analytics=segment
  • [ ] with-dedicated-emulation
  • [ ] workspace-feature-flags Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • [ ] /werft with-local-preview If enabled this will build install/preview
  • [ ] /werft with-preview
  • [ ] /werft with-large-vm
  • [x] /werft with-gce-vm If enabled this will create the environment on GCE infra
  • [ ] with-integration-tests=all Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • [ ] with-monitoring

/hold

Edward13ruf avatar Aug 29 '23 12:08 Edward13ruf

Simplified this MR to aid with pushing the auth through to the Bob. This will be in support of the changes in #18604

Edward13ruf avatar Sep 13 '23 16:09 Edward13ruf

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 15 '23 10:10 stale[bot]