gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

[installer] Refactor envvars before release

Open Pothulapati opened this issue 3 years ago • 1 comments

Description

This PR does a cleanup on the environment variables as now they are kind-off a public contract, which means its better to be verbose and meaningful as possible. Once the release is done, it would be harder to do the same.

This has the following changes:

  • Rename REG prefix to REGISTRY
  • Change REG_INCLUSTER_STORAGE_S3_BUCKETNAME to REGISTRY_INCLUSTER_STORAGE_S3_BUCKET_NAME
  • Change COMPONENT_PROXY_SERVICE_SERVICETYPE to COMPONENT_PROXY_SERVICE_TYPE

Signed-off-by: Tarun Pothulapati [email protected]

Related Issue(s)

Fixes #13151

How to test

Release Notes

[installer] Refactor envvars before release

Documentation

Werft options:

  • [ ] /werft with-preview
  • [ ] /werft with-integration-tests=all Valid options are all, workspace, webapp, ide

Pothulapati avatar Sep 21 '22 13:09 Pothulapati

/hold

Pothulapati avatar Sep 21 '22 13:09 Pothulapati

/unhold

Pothulapati avatar Sep 22 '22 11:09 Pothulapati