Connect via SSH button appears even when SSH not enabled

[mrsimonemms]

Bug description

There are likely other ways to connect to SSH in addition to the documented one. These should also be disabled appropriately

When starting a workspace, the home screen's "More Actions" button has a "Connect via SSH" option. This is always enabled, even when SSH has not been configured by the Installer.

This screenshot is from my own self-hosted instance where SSH has not been enabled (it's running on a Hetzner instance, which hardcodes port 22 for SSH for accessing the node).

Steps to reproduce

Configure a self-hosted instance, leaving the SSH option (if using KOTS) disabled

Workspace affected

self-hosted

Expected behavior

"Connect via SSH" only appears if it's configured.

Reasoning being that I can foresee a slew of tickets saying "why can I not connect via SSH" which are due to the option not being configured.

Example repository

No response

Anything else?

It's likely that this will require a config change in the Installer in addition to the SSHGatewayHostKey. If so, this will also need going into the KOTS config.

Internal discussion

[loujaybee]

Adding note that this would also apply to desktop IDE's, including JetBrains and (soon to be) VS Code Desktop, as they all use (or will soon use) the SSH gateway under the hood.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.