gitlab-ci-runner icon indicating copy to clipboard operation
gitlab-ci-runner copied to clipboard

[ISSUE-37] [ISSUE-82] Encode trace message before update build

Open deeky666 opened this issue 11 years ago • 1 comments

First off I am not a Ruby developer so please bare with me if this might not be the solution to go. This PR fixes a problem where the build trace being sent to the coordinator during update build breaks the runner resulting in an infinite running build (see issues https://github.com/gitlabhq/gitlab-ci-runner/issues/37 and https://github.com/gitlabhq/gitlab-ci-runner/issues/82. The problem is if the build trace contains invalid UTF-8 byte sequences, the PUT request fails during update build and leaves the runner in an inconsistent state where it cannot break out again. It's just outputting Submitting build 379 to coordinator...failed over and over again. The result is that the runner has to be killed and restarted. I adopted a fix suggested here to come around this issue.

deeky666 avatar Mar 22 '14 13:03 deeky666

@randx Looks good to merge

jvanbaarsen avatar Jun 22 '14 12:06 jvanbaarsen