gitlab4j-api icon indicating copy to clipboard operation
gitlab4j-api copied to clipboard

use generics in SearchApi

Open exaV opened this issue 1 year ago • 3 comments

as proposed in https://github.com/gitlab4j/gitlab4j-api/issues/1134

exaV avatar Jul 01 '24 16:07 exaV

It should work but I was unable to get the integration test to work. It fails with (even without my changes)

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.391 s <<< FAILURE! - in org.gitlab4j.api.TestSearchApi
org.gitlab4j.api.TestSearchApi  Time elapsed: 0.391 s  <<< ERROR!
org.gitlab4j.api.GitLabApiException: invalid_grant

exaV avatar Jul 01 '24 16:07 exaV

Okay I was able to get the tests to work. After my latest change all tests in TestSearchApi are green.

To get it to run I had to remove seedData() method in org.gitlab4j.api.SetupIntegrationTestExtension#beforeAll in my local copy of the code.

exaV avatar Jul 02 '24 08:07 exaV

@jmini please review

exaV avatar Jul 02 '24 08:07 exaV

@jmini Please let me know if you need me to change something to get this merged

exaV avatar Sep 24 '24 08:09 exaV

Yes it is still on my TODO list to review this. Sorry for the delay.

jmini avatar Sep 25 '24 08:09 jmini

Thank you very much for this contribution 🎉

jmini avatar Oct 12 '24 06:10 jmini