Unable to remove all/last topics from project

[Jenson3210]

This line makes it impossible to remove the last topic from a project.

Imo, if i do not want to make changes to that property, i should provide null, not empty list.

As this would be a breaking change (perhaps people today are relying on empty list making no changes), I did not start a PR.

[jmini]

You mean:

https://github.com/gitlab4j/gitlab4j-api/blob/6c06521abedebedad64a47b48960f570fba48dd7/src/main/java/org/gitlab4j/api/ProjectApi.java#L1344-L1346

&& !project.getTopics().isEmpty() should be removed?

Then the semantic would be:

• null: no change
• empty list: remove the topics.

Maybe I didn't get you right.

[Jenson3210]

That's indeed what I meant. At this moment I cannot remove the last topic as this would then not send topics argument.

Wrote my own ProjectsApi extending this one and overwrote that method only and removal worked by sending empty list.