githubwing
共享元素是可以滑动的吧
Could you please revert showing three dots button background while hovering albums and faces, it's really disruptive. In the addition it doesn't follow current theme, it's always shown in light theme.
before:
https://github.com/immich-app/immich/assets/15554561/04b21f4b-19b8-4767-841a-6cc623d1173f
PR:
https://github.com/immich-app/immich/assets/15554561/92d3ff08-3698-4e09-8c64-f8116acf41c9
Hey @waclaw66, thanks for the feedback!
The more prominent background on the icon was intentional, to give the button guaranteed color contrast in photos where the upper portion is brighter, such as an overexposed sky. To demonstrate, here's what the icon looks like on a white background:
Before the PR (light mode):
After the PR (light mode):
I do see what you mean about it being jarring having a light icon in dark mode. What would you think about leaving the more prominent background, but making it responsive to light mode vs dark mode?
The main (subjective) problem I have with this PR is that the three dot button background is shown immediately after album/face is hovered. When you hover mouse across multiple albums that moving big three dot button is like crosshair and distorts the impression of elegance. I would preffer to not show the three dot button background immediately when album/face is hovered, but when the button itself is hovered, like it was before and also Google Photos does it. The three dot button background color is just minor thing, it can stay as it is now always in light theme. Thanks for consideration my proposal.
@ben-basten The only change you need to do is to change color="opaque" attribute on CircleIconButton element within album and people card to work as below. Thanks.
https://github.com/immich-app/immich/assets/15554561/3a37ca60-9bfe-4f74-b170-b772d002b175
@waclaw66 I have another icon-related PR in the works, and I can add it there once I get some time to test it out.