vscode-github-actions icon indicating copy to clipboard operation
vscode-github-actions copied to clipboard

Invalid warnings in problems for Github Actions YML

Open kvenkatrajan opened this issue 9 months ago • 1 comments

Describe the bug This bug was originally created in this repo : https://github.com/microsoft/GitHub-Copilot-for-Azure/issues/206 by accident

Missing required input app_location keeps appearing when it's missing from close pull request action: close_pull_request_job: if: github.event_name == 'pull_request' && github.event.action == 'closed' runs-on: ubuntu-latest name: Close Pull Request Job steps:

  • name: Close Pull Request id: closepullrequest uses: Azure/static-web-apps-deploy@v1 with: azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN}} action: "close"

To Reproduce Steps to reproduce the behavior:

  1. With this workflow '...'
  2. Do this '...'
  3. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Extension Version v1.x.y

Additional context Add any other context about the problem here.

CC : Original user : aviscoreTH

kvenkatrajan avatar Apr 07 '25 16:04 kvenkatrajan

From its metadata (action.yml) and doc, the Azure/static-web-apps-deploy@v1 action does mark its input app_location required.

As the vscode-github-actions extension knows necessity of inputs from the action.yml of the corresponding action, I think the reported warning is valid, even if the input app_location is actually optional.

muzimuzhi avatar Apr 17 '25 19:04 muzimuzhi