vscode-github-actions icon indicating copy to clipboard operation
vscode-github-actions copied to clipboard

feat: support git sub directory #345

Open tjx666 opened this issue 1 year ago • 3 comments

This will fix #345.

The codebase now not consider the condition user open a sub directory of one git repo.

Example repo: https://github.com/tjx666/node-action-test

For example you project's path is: /code/repo, but you open vscode at /code/repo/web.

because when you open a sub directory of one git repo, the workflowUri /code/repo/.github/test.yml is outside /code/repo/web, will result code like following will return undefined:

const workspaceFolder = vscode.workspace.getWorkspaceFolder(workflowUri);

Note

I test locally, works fine. The only situation may be problem is:

path.relative(gitRepoFolderUri.path, workflowUri.path);

I don't known whether it will works on web environment.

tjx666 avatar Aug 23 '24 07:08 tjx666

We're not currently approving/merging pull requests for this repo except for security vulnerability/high priority stuff (more on that soon), so no ETA on getting this reviewed. I would highly suggest adding a good pr description though, as that will help when we start triaging what to review 👍

felipesu19 avatar Aug 23 '24 11:08 felipesu19

@felipesu19 I write some description

tjx666 avatar Aug 23 '24 12:08 tjx666

seems will not checked recently, I publish my own version here: YuTengjing.vscode-github-actions-pro

tjx666 avatar Aug 27 '24 18:08 tjx666