vscode-github-actions icon indicating copy to clipboard operation
vscode-github-actions copied to clipboard

Indentation switches from 2 to 4 spaces if a step uses `env:` or `with:`

Open xt0rted opened this issue 2 years ago • 1 comments

Describe the bug

If a job contains a step which uses env: or with: then the indentation on subsequent lines switches from 2 spaces to 4 spaces. The issue seems to only persist for the rest of the given job and resets in the next one.

To Reproduce

  1. Start out with this file

    on: push
    
    jobs:
      test:
        runs-on: ubuntu-latest
    
        steps:
          - name: Step 1
            run: echo "step 1"
    
          #- name: Step 2
    
          - name: Step 3
            uses: actions/checkout@v2
            with:
              foo: bar
    
          #- name: Step 4
    
          - name: Step 5
            uses: echo "step 5"
            env:
              foo: bar
    
          #- name: Step 6
    
          - name: Step 7
            run: echo "step 7"
    
  2. Uncomment step 2, go to the end of the line, press enter then tab, start to type run:

  3. The resulting text should be aligned with name from the line above it

  4. Uncomment step 4, go to the end of the line, press enter then tab, start to type run:

  5. The resulting text will not be aligned with name from the line above it, instead it will be indented an extra 2 characters

  6. Uncomment step 6, go to the end of the line, press enter then tab, start to type run:

  7. The resulting text will not be aligned with name from the line above it, instead it will be indented an extra 2 characters

Expected behavior

The second line of step's 4 and 6 to be aligned with the line above it.

Screenshots

https://github.com/github/vscode-github-actions/assets/831974/7c202f2d-a1f3-4097-9735-5cc474eb625c

Extension Version

v0.25.8

Additional context

  1. The issue goes away if you switch the file's language from github-actions-workflow to yaml

  2. Adding the following to my vscode settings file doesn't help:

    "[github-actions-workflow]": {
      "editor.tabSize": 2,
      "editor.insertSpaces": true,
    },
    
  3. The issue happens with and without GitHub Copilot running

xt0rted avatar Jul 16 '23 23:07 xt0rted

Please fix this

cwalker-vizio avatar Apr 17 '24 20:04 cwalker-vizio