vscode-codeql icon indicating copy to clipboard operation
vscode-codeql copied to clipboard

Failing integration tests when running locally

Open aeisenberg opened this issue 4 years ago • 1 comments

When running integration tests locally, they pass the first time you run them and fail subsequently.

In particular, extensions/ql-vscode/src/vscode-tests/cli-integration/databases.test.ts should add a database from a folder fails. And I can get it passing if I clear out all of the vscode temporary databases in /private/var/folders/41/kxmfbgxj40dd2l_x63x9fw7c0000gn/T/tmp-*. (This is likely a different folder on different machines.)

The integration tests are passing on CI because they always run in a clean state.

I can think of two possibilities that might fix the problem:

  1. Run cleanup code (eg- delete all databases) after running all the tests
  2. Ensure we have a clean slate before starting any tests.

version: CodeQL extension version: 1.5.6 CodeQL CLI version: 2.6.3 Platform: darwin x64

aeisenberg avatar Oct 18 '21 22:10 aeisenberg

Now, after cleaning out my temporary directory, I can't reproduce. This may be a temporary issue.

aeisenberg avatar Oct 18 '21 22:10 aeisenberg