vscode-codeql icon indicating copy to clipboard operation
vscode-codeql copied to clipboard

Less obtrusive way to ask users to collect telemetry

Open isidorn opened this issue 1 year ago • 5 comments

Hi VS Code PM Here 👋

  1. Install CodeQl
  2. See telemetry dialog 🐛

Here are our telemetry collection guidelines https://code.visualstudio.com/api/extension-guides/telemetry

Based on that I strongly suggest that you do not show this dialog, but instead just respect the respect the isTelemetryEnabled and onDidChangeTelemetryEnabled from the vscode API. That will make a much smoother user experience, and the user just has to disable telemetry once in vscode and all the extensions will respect that. Thanks

Image

fyi @TylerLeonhardt

isidorn avatar Jul 25 '24 07:07 isidorn

Hi @isidorn

Thanks for creating this issue and for the recommendation. I'll discuss this change with the team.

jf205 avatar Aug 05 '24 13:08 jf205

Discussed with the team: we agree that we should respect the isTelemetryEnabled and onDidChangeTelemetryEnabled from the vscode API. Currently unsure what size effort this would be and therefore also unsure when we'll be able to pick it up.

jf205 avatar Aug 05 '24 13:08 jf205

Thanks for discussing. I do not think this should be a large investment.

isidorn avatar Aug 05 '24 14:08 isidorn

@isidorn We discussed this a little further as a team, we're onboard with making this change but it's not something that we think we can tackle right now. Even though the investment shouldn't be too large, we're working towards some tight deadlines for shipping new features at Universe and can't take on anything else unless absolutely necessary.

I'm going to set this up for us to revisit it after Universe when I expect we'll have more capacity to take this on. If you think this is a mistake, please let me know and/or re-add this issue to our team board to be re-triaged

stonish avatar Aug 08 '24 14:08 stonish

Post Universe makes sense. Thank you!

isidorn avatar Aug 08 '24 15:08 isidorn