vscode-codeql icon indicating copy to clipboard operation
vscode-codeql copied to clipboard

Extension erroneously suggests certain QL keywords in QLDoc

Open Marcono1234 opened this issue 3 years ago • 1 comments

Describe the bug Possibly related to #391 and #556

The extension erroneously suggests certain QL keywords while writing QLDoc, these keywords seem to be affected: class, extends, from, import, select, where

Also a bit annoying is that these suggestsions pop up automatically when you write a period (.), and when you then press Enter to continue in the next line, you actually select that suggested keyword instead.

Screenshot showing the suggestsions pop-up

Version Extension:

CodeQL extension version: 1.7.0 
CodeQL CLI version: 2.11.0 
Platform: win32 x64

VS Code:

Version: 1.71.2 (user setup)
Commit: 74b1f979648cc44d385a2286793c226e611f59e7
Date: 2022-09-14T21:03:37.738Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.19043
Sandboxed: No

To reproduce

  1. Open the Quick Query
  2. Write any small query
  3. Write a QLDoc for the file, e.g.
    /**
     * test<HERE>
     */
    
  4. At the position marked with <HERE> write a period (.) :x: Bug: The extension suggests QL keywords

Expected behavior No QL keywords should be suggested in QLDoc.

Marcono1234 avatar Oct 03 '22 17:10 Marcono1234

Thanks for reporting. This seems to be an issue with our textmate grammar.

aeisenberg avatar Oct 03 '22 17:10 aeisenberg