scientist icon indicating copy to clipboard operation
scientist copied to clipboard
verified publisher icon github

Fix example code in README

Open tricknotes opened this issue 3 years ago • 0 comments

  • A method that has ? suffix should return boolean, but this method return an object that respond to valid?.
  • All other examples don't have ?.
    • https://github.com/github/scientist/blob/8d9fd4ec676a0d3ba3be868b24415384108da2f0/README.md#L44
    • https://github.com/github/scientist/blob/8d9fd4ec676a0d3ba3be868b24415384108da2f0/README.md#L152
    • https://github.com/github/scientist/blob/8d9fd4ec676a0d3ba3be868b24415384108da2f0/README.md#L167
    • https://github.com/github/scientist/blob/8d9fd4ec676a0d3ba3be868b24415384108da2f0/README.md#L251
    • https://github.com/github/scientist/blob/8d9fd4ec676a0d3ba3be868b24415384108da2f0/README.md#L498
    • https://github.com/github/scientist/blob/8d9fd4ec676a0d3ba3be868b24415384108da2f0/README.md#L553

tricknotes avatar Jan 06 '23 05:01 tricknotes