rally icon indicating copy to clipboard operation
rally copied to clipboard

Support for validation of PR body OR title OR commits

Open ineffyble opened this issue 5 years ago • 3 comments

Is your feature request related to a problem? Please describe. As a team leader, I want to encourage my team to link their work to Rally artifacts, without being prescriptive in how they do this.

Describe the solution you'd like There should be an option to validate that a Rally artifact is present in one of the supported fields.

ineffyble avatar Dec 04 '20 02:12 ineffyble

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

github-actions[bot] avatar Jan 04 '21 01:01 github-actions[bot]

This should stay open.

ineffyble avatar Jan 04 '21 04:01 ineffyble

How about making this work similar to Flag Enums in C#. Users could set a single value, locationsToCheck and pass an array of the locations they would want this bot to check. This could also help satisfy https://github.com/github/rally/issues/121 if it was deemed something this Probot would like to support.

An additional option could be added to change how many locations are required (to continue the existing and-ish behavior): minimumLocations (the name could be made better...).

Example

# .github/rally.yml
locationsToCheck:
- prTitle
- prBody
# - commit
# - branch

minimumLocations: 1

JoshuaTheMiller avatar Jan 27 '22 02:01 JoshuaTheMiller