platform-samples icon indicating copy to clipboard operation
platform-samples copied to clipboard

Problem with pre-receive hook if there is whitespace character in file/folder name

Open windwalker78 opened this issue 5 years ago • 1 comments

Hello,

This is a suggestion for a change in: "pre-receive-hooks/block_file_extensions.sh". When you try to push an blob object, which has whitespace in its name, the current loop will break. My suggestion is to transform:

    for FILE  in `git log -1 --name-only --pretty=format:'' $COMMIT`;
    do
      case $FILE in
      *.zip|*.gz|*.tgz )
        echo "Hello there! We have restricted committing that filetype. Please see Dave in IT to discuss alternatives."
        exit 1
        ;;
      esac
    done

into:

      while IFS= read -r FILE; do
        case "$FILE" in
          *.zip|*.gz|*.tgz )
          echo "Hello there! We have restricted committing that filetype. Please see Dave in IT to discuss alternatives."
          exit 1
        esac
      done <<< "$(git log -1 --name-only --pretty=format:'' $COMMIT)"

windwalker78 avatar Aug 12 '20 08:08 windwalker78