pages-gem icon indicating copy to clipboard operation
pages-gem copied to clipboard

Markdown parser and settings appear to be outdated locally

Open nickserv opened this issue 5 years ago • 1 comments

Before submitting an issue, please be sure to

This issue affects

  • [ ] The site generated by GitHub Pages
  • [x] Building sites locally

The GitHub Pages Gem is intended to help users replicate the GitHub Pages build environment locally. If your issue affects both the hosted version and the version previewed locally, you may be better suited reporting seeking support in other forums.

What did you do (e.g., steps to reproduce)

index.md

<section>

# Heading

More...

</section>

What did you expect to happen?

Jekyll should use the same markdown parser and settings locally as GitHub Pages.

<section>
  <h1 id="heading">Heading</h1>
  <p>More…</p>
</section>

What happened instead?

Jekyll seems to incorrectly use its own default Kramdown parser instead of GFM CommonMark, and as a result cannot handle Markdown in HTML or smart ellipses.

<section>

# Heading

More...

</section>

Additional information

  • Link to the source repo (if applicable): https://github.com/nickmccurdy/eslint-config-modern/tree/2699a9c01e68535a3a087759cb11e5f82905db88/docs

As a workaround, I guessed at what GitHub's Jekyll config was and ended up using this, which works the same with this example both locally and on GitHub Pages:

markdown: CommonMarkGhPages
commonmark:
  options: ["SMART"]

However, I think the gem should replicate this functionality automatically to keep local testing consistent with GitHub. I'm also not sure if I'm missing other options that may differ in both environments.

nickserv avatar Jul 21 '20 11:07 nickserv

Looking at the GFM spec and the commonmarker options (assuming they are up to date), it looks like there may be a few other things to be enabled too.

A few that seem likely..

0xdevalias avatar Jul 22 '20 00:07 0xdevalias