opensource.guide icon indicating copy to clipboard operation
opensource.guide copied to clipboard

Update index.html

Open Yashika0108 opened this issue 1 year ago • 1 comments

This works better . The <div> with class container-lg is not closed properly, it should be closed after the loop that generates article cards.

  • The images are loaded from a specific path (/assets/images/illos/). Make sure this path is correct in your project structure.

Error- Also the word YouTube doesn't changes its language as others changes

  • [x] Have you followed the contributing guidelines?
  • [x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Yashika0108 avatar Oct 15 '24 21:10 Yashika0108

You can't remove the liquid templating. Please place that back and then we can look at the other changes. Look at your deployment to confirm. Also the word Youtube is not in the index.html. The repeated description on this PR makes me think bot. Please prove otherwise. Cheers.

jmeridth avatar Oct 20 '24 17:10 jmeridth

Esto funciona mejor. La <div>clase with container-lgno está cerrada correctamente, debería cerrarse después del bucle que genera las tarjetas de artículos.

  • Las imágenes se cargan desde una ruta específica ( /assets/images/illos/). Asegúrate de que esta ruta sea correcta en la estructura de tu proyecto.

Error- Además la palabra YouTube no cambia su idioma como cambian otras

  • [x] ¿Has seguido las pautas para contribuir ?
  • [x] ¿Ha explicado qué hacen sus cambios y por qué agregan valor a las Guías?

Tenga en cuenta: cerraremos su PR sin comentarios si no marca las casillas anteriores y proporciona TODA la información solicitada.

Alejandrswu avatar Oct 22 '24 23:10 Alejandrswu

A first-level heading

A second-level heading

A third-level heading

Yopoto avatar Oct 28 '24 04:10 Yopoto

Due to lack of response and the removal of some of the liquid templating that shows it breaks rendering, I am closing this PR. @Yashika0108 please reopen and fix if you would like us to review again. Cheers.

jmeridth avatar Oct 30 '24 02:10 jmeridth