markup icon indicating copy to clipboard operation
markup copied to clipboard

markup: blockquote CSS has inconsistent margins

Open westurner opened this issue 1 year ago • 2 comments

blockquote CSS in Markdown previews and renders has inconsistent margins.

I think this may be a regression, but I don't have any screenshots of it having been working.

/* current CSS* /
.markdown-body p, .markdown-body blockquote, .markdown-body ul, .markdown-body ol, .markdown-body dl, .markdown-body table, .markdown-body pre, .markdown-body details {
  margin-top: 0;
  margin-bottom: var(--base-size-16);
}

Screenshot from 2024-09-10 12-56-05

/* suggested CSS */
.markdown-body p, .markdown-body blockquote, .markdown-body ul, .markdown-body ol, .markdown-body dl, .markdown-body table, .markdown-body pre, .markdown-body details {
  margin-top: var(--base-size-8);
  margin-bottom: var(--base-size-2);
}

Screenshot from 2024-09-10 12-55-47

  • GitHub Discussion re: same: https://github.com/orgs/community/discussions/138296

westurner avatar Sep 10 '24 17:09 westurner

- thing1
  > blockquote without an li
  - > blockquote with an li
- thing2
  > blockquote without an li
  - a
  - > blockquote with an li
  - b
  - c
  • thing1

    blockquote without an li

    • blockquote with an li

  • thing2

    blockquote without an li

    • a
    • blockquote with an li

    • b
    • c

westurner avatar Sep 10 '24 17:09 westurner

Screenshot from 2024-09-10 14-05-55

westurner avatar Sep 10 '24 18:09 westurner

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 10 '24 12:11 github-actions[bot]

Has this been fixed?

On Sun, Nov 10, 2024, 7:09 AM github-actions[bot] @.***> wrote:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

— Reply to this email directly, view it on GitHub https://github.com/github/markup/issues/1876#issuecomment-2466709478, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMNSYYRGJPQ2XMYVG4JYDZ75EGDAVCNFSM6AAAAABN7GN67GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWG4YDSNBXHA . You are receiving this because you authored the thread.Message ID: @.***>

westurner avatar Nov 10 '24 14:11 westurner

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Feb 14 '25 12:02 github-actions[bot]

This is not yet fixed

On Fri, Feb 14, 2025, 7:10 AM github-actions[bot] @.***> wrote:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

— Reply to this email directly, view it on GitHub https://github.com/github/markup/issues/1876#issuecomment-2659171431, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMNSYO3TCE7BDTQAQ7H532PXMK3AVCNFSM6AAAAABN7GN67GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZGE3TCNBTGE . You are receiving this because you authored the thread.Message ID: @.***> [image: github-actions[bot]]github-actions[bot] left a comment (github/markup#1876) https://github.com/github/markup/issues/1876#issuecomment-2659171431

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

— Reply to this email directly, view it on GitHub https://github.com/github/markup/issues/1876#issuecomment-2659171431, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMNSYO3TCE7BDTQAQ7H532PXMK3AVCNFSM6AAAAABN7GN67GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZGE3TCNBTGE . You are receiving this because you authored the thread.Message ID: @.***>

westurner avatar Feb 15 '25 20:02 westurner

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 17 '25 12:04 github-actions[bot]