gitignore icon indicating copy to clipboard operation
gitignore copied to clipboard

Add TestFramework and fix Addressables in Unity.gitignore

Open mikerochip opened this issue 7 months ago • 4 comments

Reasons for making this change

This was originally a 3+ year old PR that I'd accidentally closed while trying to update.

  • Add more complete Addressables ignores (e.g. ServerData, link.xml)
  • Fix incorrect comment about Android Assets (aa refers to Addressable Assets)
  • Add auto-generated InitTestScene* files from Unity's Test Framework

Links to documentation supporting these rule changes

Official Unity packages do not perfectly document their ignorable files, unfortunately.

Merge and Approval Steps

  • [x] Confirm that you've read the contribution guidelines and ensured your PR aligns
  • [x] Ensure CI is passing
  • [ ] Get a review and Approval from one of the maintainers

mikerochip avatar Jun 08 '25 03:06 mikerochip

@mikerochip Would you be open to splitting up changes and please provide official doc links for changes? It's difficult to review and accept changes otherwise.

wirecat avatar Jun 13 '25 22:06 wirecat

@mikerochip Would you be open to splitting up changes and please provide official doc links for changes? It's difficult to review and accept changes otherwise.

@wirecat Totally fine with splitting up changes, however I can't provide official doc links if there are none in certain cases. A lot of Unity is like that.

How about I make these changes?

  • Reduce this PR to just Test Framework and Addressables
  • Remove the OS stuff, VS Code, Rider stuff, mono_crash*

Sound reasonable?

mikerochip avatar Jun 13 '25 22:06 mikerochip

@wirecat I just made the above changes. Hopefully the PR looks cleaner now.

mikerochip avatar Jun 13 '25 23:06 mikerochip

Simplified Rider and moved to https://github.com/github/gitignore/pull/4668 since apparently they have been embedding .gitignore files inside the .idea folders for some time now according to this comment. There is an epic StackOverflow thread about how this has changed over time https://stackoverflow.com/questions/11968531/what-to-gitignore-from-the-idea-folder

mikerochip avatar Jun 13 '25 23:06 mikerochip

في السبت، ٢١ يونيو ٢٠٢٥، ١٢:٣٥ ص Daniel Johnson @.***> كتب:

@.**** commented on this pull request.

In Unity.gitignore https://github.com/github/gitignore/pull/4662#discussion_r2159689168:

/[Aa]ssets/Plugins/Editor/JetBrains* +.idea/

Thank you for that!

— Reply to this email directly, view it on GitHub https://github.com/github/gitignore/pull/4662#discussion_r2159689168, or unsubscribe https://github.com/notifications/unsubscribe-auth/BTKHXEL2KSWHYV2R6UGUUJ33ER5DNAVCNFSM6AAAAAB62TZUGWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNBXGMYTINBUGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

COMPUTEX2025 avatar Jun 20 '25 21:06 COMPUTEX2025