gitignore icon indicating copy to clipboard operation
gitignore copied to clipboard

Update Node.gitignore

Open lwabish opened this issue 2 years ago • 3 comments

Reasons for making this change:

Is it a little arbitrary to ignore logs directory? In golang ,some common packages name themselves as logs, for example, k8s.io/component-base/logs

lwabish avatar May 29 '23 07:05 lwabish

Ignoring the logs dir in the root dir instead of ignoring it globally won't be better?

as:

/logs

spirit-x64 avatar Dec 13 '23 11:12 spirit-x64

Ignoring the logs dir in the root dir instead of ignoring it globally won't be better?

as:


/logs

Seems good

lwabish avatar Dec 14 '23 00:12 lwabish

Ignoring the logs dir in the root dir instead of ignoring it globally won't be better?

as:

/logs

I have updated this PR according to this suggestion, which changed logs to /logs

lwabish avatar Dec 21 '23 01:12 lwabish