github-ds icon indicating copy to clipboard operation
github-ds copied to clipboard

expires_at is stored as a database datetime column

Open wowyzga opened this issue 3 years ago • 0 comments

Context

During the DST to standard time change, when the SQL server is running in a local time zone, records cannot be found when expires_at is set to 1 hour.

Given a PST time and a fallback to standard time at 2 AM, 1 hour from 1 AM, is going to be still 1 AM. The date s converted to the same date that was entered and few seconds after the record cannot be found again.

The expires_at column should be timezone agnostic, possible solution would be to store it as an integer (epoch time),

wowyzga avatar Nov 10 '22 21:11 wowyzga