gh-ost icon indicating copy to clipboard operation
gh-ost copied to clipboard

Dev-where branch : Add a feature to filter the data you need

Open cenkore opened this issue 6 years ago • 14 comments

The main usage scenarios are as follows:

  1. If you need to clean up some of the data before you doing the gh-ost release, it can release with -where-reserve-clause directly and you don't need to do a clean up first.

  2. If you just wanna clear a lot of data, especially for the amount of cleaning is greater than the amount of retention, it can avoid DELETE + OPTIMIZE operation.

add 2 flags:

  • where-reserve-clause: used for only copy where clause stmt values
  • force-query-migration-range-values-on-master: if you use where-reserve-clause flag, by default, will query initial migration range values with corresponding where clause stmt on slave. Also you can specify this flag to true , it will query on master and not care where clause stmt like usual and the where clause stmt would be used at copy rows to gho table.

modify 1 flag -alter: you can specify Noop if you just wanna do a table slimming and not change the table structure

cenkore avatar Feb 26 '19 05:02 cenkore

@shlomi-noach can you take a look ? were really stuck here .

cenkore avatar Mar 19 '19 05:03 cenkore

what needs to be done

sierra2019 avatar Mar 28 '19 19:03 sierra2019

excellent feature, when will this feature merge into the trunk?

dikang123 avatar Apr 18 '19 02:04 dikang123

nobody filled me in on what is going on so i am confused

sierra2019 avatar Apr 18 '19 13:04 sierra2019

ok thank you

On Wed, Apr 17, 2019 at 9:45 PM dikang123 [email protected] wrote:

excellent feature, when will this feature merge into the trunk?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/github/gh-ost/pull/718#issuecomment-484335101, or mute the thread https://github.com/notifications/unsubscribe-auth/ALVH5LQEVB6I5DDYJ5LD5XLPQ7OEPANCNFSM4G2FQ3NA .

-- sierra

sierra2019 avatar Apr 18 '19 18:04 sierra2019

would this work

sierra2019 avatar Apr 25 '19 19:04 sierra2019

We would like to use gh-ost, however we need this functionality; can we expect this to be merged anytime soon?

zpatten avatar May 06 '19 23:05 zpatten

would this work

What needs to be done for this PR ? It's stuck here with "Some checks haven’t completed yet" , and I dont know how to fix it.

cenkore avatar May 09 '19 03:05 cenkore

@cenkore Looks like the CI pipeline possibly stalled out there. Maybe rebase with the latest master and push the branch up again to kick the CI bits.

zpatten avatar May 09 '19 11:05 zpatten

@cenkore Looks like the CI pipeline possibly stalled out there. Maybe rebase with the latest master and push the branch up again to kick the CI bits.

@zpatten thanks for your advice , I will try again later.

cenkore avatar May 10 '19 03:05 cenkore

I merged latest master into my branch, still stuck here 😔 Any details or build logs ?

cenkore avatar May 10 '19 08:05 cenkore