gh-codeql icon indicating copy to clipboard operation
gh-codeql copied to clipboard
verified publisher icon github

Adding windows support for install_stub

Open dilanbhalla opened this issue 3 years ago • 4 comments

Adding option to install stub for windows (codeql.cmd) so that windows users can use this GitHub managed CLI directly within the terminal or VSCode.

dilanbhalla avatar Dec 14 '22 05:12 dilanbhalla

I haven't tested this logic, as I am not sure how this is done with GitHub CLI extensions. Just wanted to offer some assistance with this feature. If one of the maintainers can help with running a test, it would be much appreciated. Also, not sure why it is failing the status check, it seems to be downloading some really old 2.6.1 database and throwing some internal CodeQL CLI failure. Would love to get some feedback on these points, thanks in advance!

dilanbhalla avatar Dec 14 '22 07:12 dilanbhalla

Thanks for the contribution!

Looks like we're hard-coding a bunch of version numbers in the test and the older version being used is no longer able to run modern queries. I could just change the versions to something more recent, but better would be to get the latest and second latest versions for these tests.

aeisenberg avatar Dec 14 '22 19:12 aeisenberg

@redsun82, that would be great. I have no way to test this easily. If you want to take this over and merge when you're comfortable, I would 100% support that.

aeisenberg avatar Nov 21 '24 18:11 aeisenberg

We should be able to test this in an Action workflow using a Windows runner.

rvermeulen avatar Jan 17 '25 17:01 rvermeulen