gh-classroom icon indicating copy to clipboard operation
gh-classroom copied to clipboard

Fix broken link to golangci-lint install instructions

Open mchisolm0 opened this issue 1 year ago • 1 comments

What are you trying to accomplish?

Fix a link that no longer works so someone wanting to contribute will go to the right webpage when trying to install golangci-lint.

fixes Issue #95

What approach did you choose and why?

Simply replaced the old URL with the new one; everything else should be the same. I did this because it was the smallest change I could make while still fixing the issue.

What should reviewers focus on?

It is possible the team actually wants the link to take the user to a different page because the official golangci-lint install page seemed to be a lot. I could see someone getting confused unnecessarily.

An alternate option would be to include instructions for some of the install methods directly in the CONTRIBUTE.md file. If this is desired, feel free to let me know and I will be happy to make that adjustment. Please just tell me if there are any strong preferences on which install methods to include.

Edit: A previous version had the last paragraph saying to include links when I meant to include the instructions themselves.

mchisolm0 avatar Feb 06 '25 04:02 mchisolm0

I do want to mention I am waiting on feedback on Issue #96 to see if the output I got was intended or not. I suspect it is irrelevant for this PR, but I wanted to mention it in case it was relevant.

mchisolm0 avatar Feb 06 '25 04:02 mchisolm0