eslint-plugin-github icon indicating copy to clipboard operation
eslint-plugin-github copied to clipboard

Fix bug in `getElementType` logic

Open khiga8 opened this issue 1 year ago • 2 comments

This PR fixes a few issues:

1. Fixing bug in getElementType logic

const mapping = {
  'Box': 'div'
}
<Box as={something} />

will be interpreted as div. Currently the linter will check the mapping if it is unable to interpret the polymorphic value. However, it should not do that because that is not a correct interpretation.

2. Fixing mjs tests that aren't running

I noticed the tests in utils aren't running even when calling npm run test.

This seems related to this change where the tests were converted to .mjs, but the .mjs tests aren't actually running. When I fixed the command, the tests are being targeted. The test will not run properly without the .js extension.

3. Drops node 14 support

Drops node 14 support per slack thread!

4. Adds node 16 support

khiga8 avatar May 16 '24 15:05 khiga8

@github/web-systems-reviewers

Node 14 builds seem to be failing. Can we drop support?

--

The answer is yes! slack thread!

khiga8 avatar May 16 '24 19:05 khiga8

:wave: Hello and thanks for pinging us! You've entered our first responder queue. An accessibility first responder will review this soon.

  • :computer: On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • :warning: If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

accessibility-bot avatar May 16 '24 20:05 accessibility-bot