docs icon indicating copy to clipboard operation
docs copied to clipboard

Update configuring-openid-connect-in-azure.md

Open wi5nia opened this issue 7 months ago • 2 comments

The version of the task doesn't exist so setting it to the newest version in the v2 family which works.

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • [ ] A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • [ ] The changes in this PR meet the docs fundamentals that are required for all content.
  • [ ] All CI checks are passing and the changes look good in the review environment.

wi5nia avatar Jun 18 '25 10:06 wi5nia

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
actions/security-for-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-azure.md fpt
ghec
ghes@ 3.17 3.16 3.15 3.14 3.13
fpt
ghec
ghes@ 3.17 3.16 3.15 3.14 3.13

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

github-actions[bot] avatar Jun 18 '25 10:06 github-actions[bot]

Thanks for opening a PR! I'll get this triaged for review.

Sharra-writes avatar Jun 19 '25 03:06 Sharra-writes

LGTM, could you resolve merge conflicts?

JamBalaya56562 avatar Jul 31 '25 04:07 JamBalaya56562

A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment.

github-actions[bot] avatar Sep 02 '25 16:09 github-actions[bot]

A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment.

Yes this should stay opened

wi5nia avatar Sep 02 '25 17:09 wi5nia

@wi5nia Would you be able to do a rebase or something else to resolve the conflicts? We changed the file structure of Actions and everything has gotten moved around. I might be able to figure out how to do it, but it would definitely be a git learning curve for me that would delay getting this merged further.

Sharra-writes avatar Sep 02 '25 21:09 Sharra-writes

@wi5nia Would you be able to do a rebase or something else to resolve the conflicts? We changed the file structure of Actions and everything has gotten moved around. I might be able to figure out how to do it, but it would definitely be a git learning curve for me that would delay getting this merged further.

what? why? I just did a fork of GH official documentation and corrected the wrong information. I have no clue about the file structure or anything...

wi5nia avatar Sep 03 '25 06:09 wi5nia

@Sharra-writes - I created a new PR if that makes any difference for you - https://github.com/github/docs/pull/40200

wi5nia avatar Sep 03 '25 07:09 wi5nia

@wi5nia That should work. It's nothing you did, we just changed a bunch of things that made this complicated. I know it's possible to fix, I'm even pretty sure it's something I could fix for you, it's just not something I've learned yet. I'll close this PR and get your new one approved.

Sharra-writes avatar Sep 03 '25 17:09 Sharra-writes