docs icon indicating copy to clipboard operation
docs copied to clipboard

Add known case with monorepos

Open dsotirakis opened this issue 8 months ago • 5 comments

Why:

Closes: https://github.com/github/docs/issues/38272 GitHub support ticket: #3380332

What's being changed (if available, include any code snippets, screenshots, or gifs):

Adds a small bit about update to monorepos where dependabot needs to take action. Looks like "namespaced" tags are better supported by git rather than tags with - as a separator.

Check off the following:

  • [ ] A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • [x] The changes in this PR meet the docs fundamentals that are required for all content.
  • [x] All CI checks are passing and the changes look good in the review environment.

dsotirakis avatar May 14 '25 13:05 dsotirakis

Thanks for submitting a PR to the GitHub Docs project!

In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the documentation.

github-actions[bot] avatar May 14 '25 13:05 github-actions[bot]

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
code-security/dependabot/troubleshooting-dependabot/troubleshooting-the-detection-of-vulnerable-dependencies.md fpt
ghec
ghes@ 3.17 3.16 3.15 3.14
fpt
ghec
ghes@ 3.17 3.16 3.15 3.14

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

github-actions[bot] avatar May 14 '25 13:05 github-actions[bot]

Thanks for opening a PR! I'll get this triaged for review.

Sharra-writes avatar May 14 '25 17:05 Sharra-writes

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:

github-actions[bot] avatar May 14 '25 17:05 github-actions[bot]

This is a gentle bump for the docs team that this PR is waiting for technical review.

github-actions[bot] avatar Jun 16 '25 16:06 github-actions[bot]

This is also now closed - https://github.com/github/docs/issues/38272#event-18298597397. Could we please re-open it? (cc @Sharra-writes)

dsotirakis avatar Jun 30 '25 07:06 dsotirakis

@dsotirakis Hi! 👋 one of our engineers opened a PR on your fork to update some formatting and some of the language to clarify how Dependabot works. Would you be willing to merge that? Then I can work on getting a writing review.

Sharra-writes avatar Jul 24 '25 21:07 Sharra-writes

@Sharra-writes 👋 Thanks for following up! Reviewed and merged!

dsotirakis avatar Jul 25 '25 06:07 dsotirakis

@dsotirakis Yeah, sorry it took a while. It was difficult finding someone who knew about it. 😅 I'm going to correct a few basic things to match our style guide, and then I'll mark it for a more in-depth review from a writer.

Edit to add: Can you enable the checkbox to allow maintainer edits? It will make things much more efficient for the writing review. Thank you! https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Sharra-writes avatar Jul 25 '25 16:07 Sharra-writes

@Sharra-writes thanks, done!

dsotirakis avatar Jul 29 '25 09:07 dsotirakis

This is a gentle reminder for the docs team that this pull request is waiting for review.

github-actions[bot] avatar Aug 12 '25 16:08 github-actions[bot]

@dsotirakis I'm sorry, for longer sections or articles, I'm not the one who does reviews. I'm relatively new to the team and writing isn't my primary function, so my ability to make sure things adhere to the style guide is still a work in progress. I'm going to check in with my manager to see if there's someone I can poke a bit to get some reviews done, because you're not the only one in the repo waiting. We did just come off a big project where everyone was busy, but I think things have quieted down a bit. 🤞

Sharra-writes avatar Aug 26 '25 19:08 Sharra-writes

@am-stead 👋 Thanks so much for the review! Moved it as you suggested!

dsotirakis avatar Sep 23 '25 07:09 dsotirakis

Thanks @dsotirakis! I'll get this merged! ✨

am-stead avatar Sep 23 '25 08:09 am-stead

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Sep 23 '25 09:09 github-actions[bot]