docs icon indicating copy to clipboard operation
docs copied to clipboard

Corrected context window sizes for o1-preview and o1-mini models

Open carloshvp opened this issue 1 year ago • 4 comments

The correct values are taken from the official models pages: https://github.com/marketplace/models/azure-openai/o1-preview https://github.com/marketplace/models/azure-openai/o1-mini

Why:

Closes: https://github.com/github/docs/issues/34911

What's being changed (if available, include any code snippets, screenshots, or gifs):

Corrected context window sizes, according to official model pages referred https://github.com/marketplace/models/azure-openai/o1-preview https://github.com/marketplace/models/azure-openai/o1-mini

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

carloshvp avatar Oct 12 '24 11:10 carloshvp

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Oct 12 '24 11:10 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
github-models/prototyping-with-ai-models.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar Oct 12 '24 11:10 github-actions[bot]

@carloshvp Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar Oct 14 '24 14:10 nguyenalex836

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:

github-actions[bot] avatar Oct 15 '24 11:10 github-actions[bot]

Thanks for suggesting this change. I think we need to make our docs clearer as these are the service limits when the service is provided without costs on GitHub Models. While the models do support a larger context window, the service constrains the number of tokens when users are using the free service. I'll make a future docs PR to make the clearer around this table.

matthewisabel avatar Nov 13 '24 01:11 matthewisabel

Thank you @matthewisabel for the clarification. Should I close this PR then?

carloshvp avatar Nov 13 '24 12:11 carloshvp

@carloshvp I'll go ahead and close this 💛 Thank you so much for your willingness to contribute to our docs!

If you're looking for an issue to pick up, take a look at our help wanted section to find open issues you can work on ✨

nguyenalex836 avatar Nov 13 '24 16:11 nguyenalex836