docs icon indicating copy to clipboard operation
docs copied to clipboard

Disabling two-factor authentication documentation update

Open georgethemarmot opened this issue 1 year ago â€ĸ 4 comments

Why:

Documentation was not up to date with website changes

What's being changed (if available, include any code snippets, screenshots, or gifs):

Image and description of where to disable 2fa

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

georgethemarmot avatar Oct 04 '24 00:10 georgethemarmot

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Oct 04 '24 00:10 welcome[bot]

Automatically generated comment â„šī¸

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/securing-your-account-with-two-factor-authentication-2fa/disabling-two-factor-authentication-for-your-personal-account.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar Oct 04 '24 00:10 github-actions[bot]

@georgethemarmot Thank you for opening a PR! ✨ While your changes appear to be correct, I'll get this triaged for review by our technical writing team to validate content / style changes 💛

nguyenalex836 avatar Oct 04 '24 14:10 nguyenalex836

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:

github-actions[bot] avatar Oct 07 '24 10:10 github-actions[bot]

how can i contribute ?

kashyapanjali avatar Oct 24 '24 10:10 kashyapanjali

@kashyapanjali Hello! 👋 While there aren't any opportunities to contribute regarding this PR, take a look at our help wanted section to find open issues you can work on ✨

nguyenalex836 avatar Oct 24 '24 14:10 nguyenalex836

disable-two-factor-authentication

New image to use

subatoi avatar Nov 18 '24 08:11 subatoi

This PR has been automatically closed because there has been no response to to our request for more information from the original author. Please reach out if you have the information we requested, or open a new issue to describing your changes. Then we can begin the review process.

github-actions[bot] avatar Nov 25 '24 17:11 github-actions[bot]

@georgethemarmot Howdy! 👋 We wanted to check in and see if you've had a chance to review @subatoi's suggestions, including the new image he provided! The branch conflicts will also need to be resolved as well 💛

If you'd rather us fix this internally, we're more than happy to do so!

nguyenalex836 avatar Nov 26 '24 18:11 nguyenalex836

This PR has been automatically closed because there has been no response to to our request for more information from the original author. Please reach out if you have the information we requested, or open a new issue to describing your changes. Then we can begin the review process.

github-actions[bot] avatar Dec 03 '24 19:12 github-actions[bot]

@georgethemarmot Just to let you know, I'm shipping a fix for this internally and have added you as a co-committer (since you use a no-reply), so we can leave this closed.

Thanks for spotting this and your interest in the docs!

subatoi avatar Dec 04 '24 08:12 subatoi

@nguyenalex836 @subatoi
Sorry I had no time to reply before. Next time I'll maybe just report it instead of opening PR.

georgethemarmot avatar Dec 08 '24 16:12 georgethemarmot

Sorry I had no time to reply before.

No problem at all!

Next time I'll maybe just report it instead of opening PR.

In general, that's often the best way to do things. We don't mind people raising PRs first, but since we have to conform to our style guide and restrictions around images (like in this case), it can introduce a bit of friction. If users raise an issue first, it gives us chance to help shape the changes, meaning, typically, less friction. Obviously there isn't much point in raising an issue first if you're only fixing a typo, though!

In this case, I went ahead and pushed a fix because you'd correctly identified something that might have been tripping people up, so thank you again!

You can see your co-committer attribution here:

https://github.com/github/docs/commit/1368bab5336e46d95d15cacd43aeb955d1353e54

subatoi avatar Dec 09 '24 07:12 subatoi