docs icon indicating copy to clipboard operation
docs copied to clipboard

Added needed call of google-github-actions/auth with credentials and changed version of google-github-actions calls

Open dundejan opened this issue 1 year ago • 3 comments

Why:

Based on my own following the tutorial and usage of .github/workflows/main.yml, I found out, that there is needed to call the auth from google-github-actions for the workflow to work properly. Also the noted versions of google-github-actions were not readable, resp. their meaning was not explained and was not obvious.

When I was solving my problem, I started a discussion at community forum here: could not load the default credentials error in deploy action to GKE, where can be seen and explained the problematic part, that leads me to this little modification.

dundejan avatar Aug 09 '24 18:08 dundejan

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Aug 09 '24 18:08 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/deployment/deploying-to-your-cloud-provider/deploying-to-google-kubernetes-engine.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar Aug 09 '24 18:08 github-actions[bot]

@dundejan Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar Aug 09 '24 18:08 nguyenalex836

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:

github-actions[bot] avatar Sep 17 '24 14:09 github-actions[bot]

@dundejan Thank you for your patience while our team reviewed! ✨ Before we make these changes to the docs, have you by chance reached out to our support team regarding the behavior you saw with the workflow?

Ideally, we would want them to have a chance to dive into this issue before we make any modifications to the docs 💛

nguyenalex836 avatar Sep 27 '24 20:09 nguyenalex836

FYI there's a similar update from Google Cloud staff last month, adding the auth in the starter workflow too: https://github.com/actions/starter-workflows/pull/2478/files#diff-92b5bbe29dbd8d2c6ae67ce2e24b44e8a82f6c5b00702b05e78cdaaf4f269662

It may however need a more systematic approach updating all the google-cloud-* examples throughout the site, though:/

janbrasna avatar Sep 30 '24 11:09 janbrasna

This PR has been automatically closed because there has been no response to to our request for more information from the original author. Please reach out if you have the information we requested, or open a new issue to describing your changes. Then we can begin the review process.

github-actions[bot] avatar Oct 07 '24 12:10 github-actions[bot]