docs icon indicating copy to clipboard operation
docs copied to clipboard

Specify allowed contexts in jobs.<job_id>.services.<service_id>.image

Open piotrekkr opened this issue 1 year ago • 3 comments

Why:

Documentation does not mention if and which context variable can be used in jobs.<job_id>.services.<service_id>.image. From my tests a subset of contexts can be used and those are: github, matrix, strategy, needs, vars and inputs.

Unfortunately, using env context is not possible. Not sure why that is. Anyhow, specifying allowed contexts in docs would be helpful when writing workflows.

I've also changed conditional service creation example because it contained invalid example that was using options context which does not exist.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Added a note about allowed contexts and fixed example conditional service creation.

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

piotrekkr avatar Jun 27 '24 11:06 piotrekkr

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/workflow-syntax-for-github-actions.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar Jun 27 '24 11:06 github-actions[bot]

@piotrekkr Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar Jun 27 '24 19:06 nguyenalex836

@piotrekkr - Thanks for raising this PR. I've asked the development team to confirm your changes before we go ahead and merge this.

hubwriter avatar Jul 01 '24 14:07 hubwriter

Closing this pull request because there is a list of available contexts in each configuration sections here.

piotrekkr avatar Jul 09 '24 20:07 piotrekkr