docs icon indicating copy to clipboard operation
docs copied to clipboard

Clarifies outputs in reusable workflows

Open APCBoston opened this issue 1 year ago • 3 comments

Why:

Closes: #32543

The existing text is not clear that the workflow level outputs: may be mapped to job-level, but not step-level outputs. Attempts to use step-level outputs do not generate an error but pass an empty output. I have added two sentences to clarify that only job-level outputs may be mapped to workflow outputs.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Two sentences at the end of the section https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-outputs-from-a-reusable-workflow. The diff should be very clear.

Check off the following:

  • [ x ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

  • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • [ x ] For content changes, I have completed the self-review checklist.

APCBoston avatar Apr 16 '24 16:04 APCBoston

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Apr 16 '24 16:04 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/reusing-workflows.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar Apr 16 '24 16:04 github-actions[bot]

@APCBoston Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar Apr 16 '24 17:04 nguyenalex836

@jc-clark your latest suggestion works for me and I have accepted it!

APCBoston avatar May 31 '24 20:05 APCBoston

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar May 31 '24 21:05 github-actions[bot]