docs icon indicating copy to clipboard operation
docs copied to clipboard

Add additional clarification about the merge queue

Open air3ijai opened this issue 1 year ago • 5 comments

Why:

PR adds additional clarification about the Merge Queue

  • Merge queue and Pull Requests checks currently are coupled
  • Link to the section where these checks are configured is added

It is a follow up of the How to ensure Github merge queue does not allow failed checks into master #75568 and probably main discussion - Pull Request Merge Queue Public Beta Feedback #46757.

Closes: None

What's being changed (if available, include any code snippets, screenshots, or gifs):

File Changes
managing-a-merge-queue.md Added additional note about merge queue

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

air3ijai avatar Feb 26 '24 15:02 air3ijai

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Feb 26 '24 15:02 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue.md fpt
ghec
ghes
fpt
ghec
ghes

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar Feb 26 '24 15:02 github-actions[bot]

@air3ijai Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar Feb 26 '24 21:02 nguyenalex836

бу програмда телеграм патписчик кушса буладими

diyaranazarova avatar Feb 28 '24 10:02 diyaranazarova

бу програмда телеграм учун патписчик йигча буладими

diyaranazarova avatar Feb 28 '24 10:02 diyaranazarova

@air3ijai Thank you for your patience while our team reviewed your PR! 💛 We made (2) small adjustments to your changes

  • Removed "Currently," at the beginning of your addition
  • Removed an extra space

I'll update the branch and get this merged once tests are passing 🍏 thank you very much for your contribution! ✨

nguyenalex836 avatar Mar 28 '24 17:03 nguyenalex836

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Mar 28 '24 17:03 github-actions[bot]

"Currently," was added as we all hope that soon these checks will be decoupled :)

Looks good, @nguyenalex836, thank you for the update!

air3ijai avatar Mar 28 '24 18:03 air3ijai