docs icon indicating copy to clipboard operation
docs copied to clipboard

Clarify merge queue merge limits

Open 4wrxb opened this issue 1 year ago • 3 comments

Why:

Add a note that merge limits do not combine merge group builds but only the merge operation to trunk. This appears to be a repeated point of confusion in discussions.

Examples of this confusion in public discussion:

  • https://github.com/orgs/community/discussions/46757#discussioncomment-5272725
  • https://github.com/orgs/community/discussions/58523

Closes:

None

What's being changed (if available, include any code snippets, screenshots, or gifs):

Source Preview Production What Changed
repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue.md fpt ghec ghes fpt ghec ghes Add note to merge limits

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

4wrxb avatar Feb 23 '24 18:02 4wrxb

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Feb 23 '24 18:02 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue.md fpt
ghec
ghes
fpt
ghec
ghes

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar Feb 23 '24 18:02 github-actions[bot]

@4wrxb Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar Feb 23 '24 20:02 nguyenalex836

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:

github-actions[bot] avatar Apr 05 '24 18:04 github-actions[bot]

@4wrxb I'll go ahead and accept the suggestions from SME on your behalf, and get this merged in for you 💛 thank you for your contribution!

nguyenalex836 avatar Apr 26 '24 18:04 nguyenalex836

Thanks @nguyenalex836, but I think @willsmythe is trying to avoid the use of an additional note all together. Give me a moment to respond to his feedback.

4wrxb avatar Apr 26 '24 18:04 4wrxb

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Apr 26 '24 18:04 github-actions[bot]