docs icon indicating copy to clipboard operation
docs copied to clipboard

Update securing-your-github-pages-site-with-https.md

Open evK1 opened this issue 2 years ago • 3 comments

Added note that Pages site must be public to obtain LE cert. Customer had an issue with this recently and it seems a fairly big oversight not to mention.

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • [ ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [ ] For content changes, I have completed the self-review checklist.

evK1 avatar Jun 30 '23 13:06 evK1

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Jun 30 '23 13:06 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pages/getting-started-with-github-pages/securing-your-github-pages-site-with-https.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Jun 30 '23 13:06 github-actions[bot]

👋 @evK1 - Thanks so much for opening a PR! I'll get this triaged for review :zap:

cmwilson21 avatar Jun 30 '23 20:06 cmwilson21

Left one suggestion to add a variable instead of the product name, but this change looks good to me. Thanks for adding this to our Docs!

Feel free to @mention me here to get this merged. ✨

@sophietheking - merge away ma'am :)

evK1 avatar Jul 12 '23 15:07 evK1

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Jul 14 '23 07:07 github-actions[bot]