docs icon indicating copy to clipboard operation
docs copied to clipboard

fix: Clarify that the example to list and delete caches on PR closure has a limit

Open erezrokah opened this issue 2 years ago â€ĸ 4 comments

Why:

Closes https://github.com/github/docs/issues/26251

What's being changed (if available, include any code snippets, screenshots, or gifs):

Added a clarification that the example deletes caches up to a limit, and not all caches. Also set the limit to the maximum value supported

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

erezrokah avatar Jun 26 '23 15:06 erezrokah

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Jun 26 '23 15:06 welcome[bot]

Automatically generated comment â„šī¸

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/caching-dependencies-to-speed-up-workflows.md fpt
ghec
ghes@ 3.9 3.8 3.7 3.6
fpt
ghec
ghes@ 3.9 3.8 3.7 3.6

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Jun 26 '23 15:06 github-actions[bot]

@erezrokah Thanks so much for opening a PR and linking it to your issue! And welcome to the community 🎉

I'll get this triaged for review :zap:

In the meantime, if you are looking for other ways to contribute, check out our help wanted section. 💖

cmwilson21 avatar Jun 27 '23 20:06 cmwilson21

Looks good to me

Thanks for the review @CBID2 🚀 What are the next steps? I can see that the checks still say "Review required"

erezrokah avatar Jul 13 '23 14:07 erezrokah

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Jul 14 '23 21:07 github-actions[bot]