docs icon indicating copy to clipboard operation
docs copied to clipboard

Patterns that start with `*` or `!` must use quotes

Open miguelsousa opened this issue 2 years ago • 3 comments

Why:

Closes: #26172

What's being changed (if available, include any code snippets, screenshots, or gifs):

Added quotes to the patterns that start with * and !.

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

miguelsousa avatar Jun 22 '23 16:06 miguelsousa

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Jun 22 '23 16:06 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/workflow-syntax-for-github-actions.md fpt
ghec
ghes@ 3.9 3.8 3.7 3.6
ghae
fpt
ghec
ghes@ 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Jun 22 '23 16:06 github-actions[bot]

@miguelsousa Thank you for opening a PR and linking it to your issue! And welcome to the community! ✨

I'll get this triaged for review! :zap:

In the meantime, if you are looking for other ways to contribute, check out our help wanted section to find open issues you can work on.

cmwilson21 avatar Jun 23 '23 13:06 cmwilson21

@cmwilson21 anything else I need to do to this PR to get it merged?

miguelsousa avatar Jul 10 '23 17:07 miguelsousa

@miguelsousa Thanks for checking in on this! It's up on the review board, so a writer will have eyes on it soon 👀

cmwilson21 avatar Jul 11 '23 13:07 cmwilson21

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Jul 25 '23 08:07 github-actions[bot]