docs icon indicating copy to clipboard operation
docs copied to clipboard

Update generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md

Open cdiamon opened this issue 2 years ago • 3 comments

Why:

The wording can be misleading: 'later' version can be read as 'older' as well as 'newer'

What's being changed (if available, include any code snippets, screenshots, or gifs):

update wording for more clarity since 'later' can be read as 'older' or 'newer'

Check off the following:

  • [ ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

cdiamon avatar Jun 20 '23 12:06 cdiamon

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Jun 20 '23 12:06 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md fpt
ghec
ghes@ 3.9 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.9 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Jun 20 '23 12:06 github-actions[bot]

@cdiamon Thanks so much for opening a PR! I'll get this triaged for review :zap:

cmwilson21 avatar Jun 21 '23 13:06 cmwilson21

Hi @cdiamon,

Thanks so much for opening a PR!

We do generally use "or later" throughout our docs to denote newer software versions, since this aligns with the our style guide conventions (we defer to the Microsoft Style Guide).

I will close this PR for now. Thank you for taking the time to contribute! ✨

am-stead avatar Jun 26 '23 19:06 am-stead