docs icon indicating copy to clipboard operation
docs copied to clipboard

public action example main.yml needs correction.

Open shailesh-vaidya opened this issue 3 years ago • 1 comments

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action

What part(s) of the article would you like to see updated?

https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action#example-using-a-public-action

The .github/workflows/main.yml file Action version is not mentioned. If someone copy-pastes this in their own repository it throws an error.

uses: actions/hello-world-docker-actionv2

Should be

uses: actions/hello-world-docker-action@v2

it's mentioned to use tag name v1 in the above steps. We should use the same in the next steps also.

Additional information

No response

shailesh-vaidya avatar Jan 07 '23 11:01 shailesh-vaidya

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Jan 07 '23 11:01 welcome[bot]

@shailesh-vaidya Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

cmwilson21 avatar Jan 09 '23 18:01 cmwilson21

Hey there, @shailesh-vaidya! Sorry about the delay in this comment, I forgot to post an update here once the PR merged.

✨Thank you for this suggestion and great job finding this!

We fixed this over in https://github.com/github/docs/pull/23284

jc-clark avatar Jan 18 '23 21:01 jc-clark