docs icon indicating copy to clipboard operation
docs copied to clipboard

Add hosts file content for GitHub's SSH keys

Open Clockwork-Muse opened this issue 3 years ago • 2 comments

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints

What part(s) of the article would you like to see updated?

The article lists the fingerprints for the various GitHub ssh keys. Unfortunately this requires users to manually and visually compare the fingerprints during the initial connection, which is an error-prone process. Instead, it would be more helpful if the article also provided the equivalent content for a known_hosts file, as gitlab does.

Additional information

Gitlab makes it much easier to import keys - they even include a copy button.

Clockwork-Muse avatar Nov 07 '22 05:11 Clockwork-Muse

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Nov 07 '22 05:11 welcome[bot]

@Clockwork-Muse Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

cmwilson21 avatar Nov 08 '22 21:11 cmwilson21

cc-ing @github/authentication for triage

hagould avatar Nov 29 '22 23:11 hagould

Thanks @Clockwork-Muse , we'll get a PR open internally to make a few changes related to the issue you've raised here. Since we'll address this internally, I'll close this issue.

vgrl avatar Dec 02 '22 00:12 vgrl

FYI @vgrl We made updates here as well.

hagould avatar Dec 05 '22 22:12 hagould

The path in the documentation is missing a slash. It currently is: ~.ssh/known_hosts It should be: ~/.ssh/known_hosts

Clockwork-Muse avatar Dec 17 '22 01:12 Clockwork-Muse

Great catch @Clockwork-Muse ! 🎉 You or anyone else is welcome to open new a PR with a quick fix 🔨 to address the missing slash in the file path on line 25.

Note also that we have frozen the docs repo over the holiday period, so PRs we won't be merging any changes until after Jan 3, 2023.

vgrl avatar Dec 19 '22 01:12 vgrl