docs icon indicating copy to clipboard operation
docs copied to clipboard
verified publisher icon github

reviewing-the-audit-log-for-your-organization: Fix links and correct typo

Open rvrvrv opened this issue 3 years ago • 4 comments

Why:

  • repository_secret_scanning_custom_pattern link is broken
  • repository_secret_scanning_push_protection link is broken
  • Protecting pushes with secret scanning has typo

Closes https://github.com/github/docs/issues/21539

What's being changed (if available, include any code snippets, screenshots, or gifs):

image

Check off the following:

  • [x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • [x] For content changes, I have completed the self-review checklist.

rvrvrv avatar Oct 21 '22 22:10 rvrvrv

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Oct 21 '22 22:10 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
organizations/keeping-your-organization-secure/managing-security-settings-for-your-organization/reviewing-the-audit-log-for-your-organization.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
 fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Oct 21 '22 22:10 github-actions[bot]

https://www.paypal.com/pools/c/8OmsxaiDuZ

On Fri, Oct 21, 2022, 6:06 PM Rich @.***> wrote:

Why:

  • repository_secret_scanning_custom_pattern link is broken
  • repository_secret_scanning_push_protection link is broken
  • Protecting pushes with secret scanning has typo

Closes #21539 https://github.com/github/docs/issues/21539 What's being changed (if available, include any code snippets, screenshots, or gifs):

[image: image] https://user-images.githubusercontent.com/55961065/197295045-f57bb3d1-b128-4901-bbc7-6990be562b1d.png Check off the following:

You can view, comment on, or merge this pull request online at:

https://github.com/github/docs/pull/21540 Commit Summary

File Changes

(1 file https://github.com/github/docs/pull/21540/files)

Patch Links:

  • https://github.com/github/docs/pull/21540.patch
  • https://github.com/github/docs/pull/21540.diff

— Reply to this email directly, view it on GitHub https://github.com/github/docs/pull/21540, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZVIUCQGC6JT7YR6Q2WQOE3WEMHVJANCNFSM6AAAAAARLRLVRQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Rambo250000000000 avatar Oct 23 '22 05:10 Rambo250000000000

@rvrvrv Thanks for submitting this PR, providing great information in the template, and for linking it to your issue! ✨

I'll get this triaged for review! ⚡

cmwilson21 avatar Oct 24 '22 15:10 cmwilson21

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Oct 26 '22 13:10 github-actions[bot]