docs icon indicating copy to clipboard operation
docs copied to clipboard

Update working-with-the-npm-registry.md

Open heliosalesjr opened this issue 3 years ago â€ĸ 6 comments

Why:

Adds a space to an example here - https://docs.github.com/packages/working-with-a-github-packages-registry/working-with-the-npm-registry

Closes [issue link]

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • [x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • [x] For content changes, I have completed the self-review checklist.

heliosalesjr avatar Oct 19 '22 02:10 heliosalesjr

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Oct 19 '22 02:10 welcome[bot]

it wasn't too much, I'd just added a space somewhere it was missing one.

heliosalesjr avatar Oct 19 '22 02:10 heliosalesjr

Automatically generated comment â„šī¸

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
packages/working-with-a-github-packages-registry/working-with-the-npm-registry.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Oct 19 '22 02:10 github-actions[bot]

@heliosalesjr Thanks so much for opening a PR! I'll get this triaged for review :zap:

Also, I updated your original post to include the link to the article 💖

cmwilson21 avatar Oct 19 '22 15:10 cmwilson21

@heliosalesjr 👋 Just checking in. Are you able to make the same change in line 145 as mentioned above? â˜ī¸

cmwilson21 avatar Oct 24 '22 19:10 cmwilson21

@heliosalesjr 👋 Just checking in. Are you able to make the same change in line 145 as mentioned above? â˜ī¸

I've tried to but I'm getting confused and I'm afraid I'll do something wrong. I'm reading all the instructions and I'll try again as soon as I figure this out, ok? If you think I'm missing something very obvious, I'd like to hear from you. Thank you!

heliosalesjr avatar Oct 25 '22 19:10 heliosalesjr

@heliosalesjr No prob! If you go to your file here and click the edit button in the top right bar, you can then scroll down to line 145 and add the missing space between "registry":"https there, too. Then commit your change again.

Hope that is the information you were asking for! 💖

cmwilson21 avatar Oct 26 '22 20:10 cmwilson21

@heliosalesjr No prob! If you go to your file here and click the edit button in the top right bar, you can then scroll down to line 145 and add the missing space between "registry":"https there, too. Then commit your change again.

Hope that is the information you were asking for! 💖

Thank you so much for your help! I think it's done now! :-)

heliosalesjr avatar Oct 26 '22 20:10 heliosalesjr

@heliosalesjr You're welcome! Thanks for providing this fix. I'll get this merged down once all the checks are passing ✅

cmwilson21 avatar Oct 27 '22 15:10 cmwilson21

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Oct 27 '22 15:10 github-actions[bot]