docs icon indicating copy to clipboard operation
docs copied to clipboard

Mention that `GITHUB_*` and `RUNNER_*` can't be set using `GITHUB_ENV` (but that `CI` can be)

Open jsoref opened this issue 3 years ago • 12 comments

Why:

Closes #19626

What's being changed (if available, include any code snippets, screenshots, or gifs):

Adding note about default vars immutability.

https://docs-20069-a70e64.preview.ghdocs.com/en/actions/learn-github-actions/environment-variables#default-environment-variables image

https://docs-20069-a70e64.preview.ghdocs.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable

image

Check off the following:

  • [x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • [ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • [ ] This pull request impacts the contribution experience
    • [ ] I have added the 'writer impact' label
    • [ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

jsoref avatar Aug 23 '22 01:08 jsoref

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/learn-github-actions/environment-variables.md fpt
ghec
ghes@ 3.9 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.9 3.8 3.7 3.6 3.5 3.4
ghae
actions/using-workflows/workflow-commands-for-github-actions.md fpt
ghec
ghes@ 3.9 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.9 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Aug 23 '22 01:08 github-actions[bot]

👋 @jsoref Thanks so much for opening a PR! I'll get this triaged for review :zap:

cmwilson21 avatar Aug 23 '22 13:08 cmwilson21

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:

github-actions[bot] avatar Sep 13 '22 06:09 github-actions[bot]

This is a gentle bump for the docs team that this PR is waiting for technical review.

github-actions[bot] avatar Oct 13 '22 20:10 github-actions[bot]

This is a gentle bump for the docs team that this PR is waiting for technical review.

github-actions[bot] avatar Nov 11 '22 16:11 github-actions[bot]

This is a gentle bump for the docs team that this PR is waiting for technical review.

github-actions[bot] avatar Dec 12 '22 16:12 github-actions[bot]

This is a gentle bump for the docs team that this PR is waiting for technical review.

github-actions[bot] avatar Jan 10 '23 16:01 github-actions[bot]

This is a gentle bump for the docs team that this PR is waiting for technical review.

github-actions[bot] avatar Feb 08 '23 16:02 github-actions[bot]

This is a gentle bump for the docs team that this PR is waiting for technical review.

github-actions[bot] avatar Mar 10 '23 16:03 github-actions[bot]

This is a gentle bump for the docs team that this PR is waiting for technical review.

github-actions[bot] avatar Apr 10 '23 16:04 github-actions[bot]

Unfortunately, due to us taking so long to review this, there are now conflicts in these files which need resolved before we can merge this:

  • content/actions/learn-github-actions/environment-variables.md
  • content/actions/using-workflows/workflow-commands-for-github-actions.md

hubwriter avatar Jun 20 '23 16:06 hubwriter

@hubwriter: can you deal w/ them? I'm unlikely to know the context of those changes.

If things are simple enough, I can do a rebase and reapply the spirit of the current head of this branch...

jsoref avatar Jun 20 '23 16:06 jsoref

@jsoref - I don't have write access to your fork of the docs repo, so I can't fix up the conflicts. I'll close this PR and make the same changes on a new PR.

hubwriter avatar Jul 17 '23 10:07 hubwriter

Changes now published:

  • https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables
  • https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable

hubwriter avatar Jul 17 '23 14:07 hubwriter