Remove unnecessary query
Pull Request checklist
~does a query removal require a changenote?~ added
I propose removing this query, as it is subsumed by the logic of EmptyBlock which does also cover statements
ran these both using MRVA on top 10 java repos
and did a check explicitly on all results from junit-team/junit4 database that the result set of EmptyBlock completely subsumed the results of the removed query
suspect it will be similar for other databases (though encourage anyone else to double check my logic on this as well)
All query authors
- [ ] A change note is added if necessary. See the documentation in this repository.
- [ ] All new queries have appropriate
.qhelp. See the documentation in this repository. - [ ] QL tests are added if necessary. See Testing custom queries in the GitHub documentation.
- [ ] New and changed queries have correct query metadata. See the documentation in this repository.
Internal query authors only
- [ ] Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to
.ql,.qll, or.qhelpfiles. See the documentation (internal access required). - [ ] Changes are validated at scale (internal access required).
- [ ] Adding a new query? Consider also adding the query to autofix.
QHelp previews:
Yes, it does need a change note, in case people wonder why they've lost some results.
Yes, it does need a change note, in case people wonder why they've lost some results.
thanks! I wasnt totally sure what changenote category to use here
I see in the doc that normally a query deletion is breaking, but this query doesnt seem to be in a pack (searching via the action artifact code scanning query list) , so I used minorAnalysis... let me know if that was not correct! thanks!