codeql icon indicating copy to clipboard operation
codeql copied to clipboard

Bazel: allow installer script to install into multiple directories, in parallel

Open redsun82 opened this issue 1 year ago • 5 comments

redsun82 avatar Jun 26 '24 14:06 redsun82

I might have overengineered it, but I think we could shave off several seconds in the final install steps for full dists if we employ this.

redsun82 avatar Jun 27 '24 08:06 redsun82

I might have overengineered it, but I think we could shave off several seconds in the final install steps for full dists if we employ this.

You think so? I'd have guessed that ripunzip already employs parallelity, so there's not so much to be gained by calling it multiple times in parallel. I guess we can see if copying the extractor files could be sped up like this. I'll put this onto my review queue, but at lower priority. I guess this'd need somewhat significant changes to how we build pack groups to be used for single-target intree dists like target/intree/codeql.

criemen avatar Jun 27 '24 10:06 criemen

It might be that most of the gain would rather come from avoiding the multiple bazel run overhead, rather than using parallelism. We can always test that out and remove the code for parallel runs if it doesn't really matter. In any case, yes, this can definitely wait.

redsun82 avatar Jun 27 '24 11:06 redsun82

Ah, a single intree-dist is currently already modelled by a single bazel run, it's just split dists that invoke bazel run multiple times (once for nolang, once for every extractor requested)

criemen avatar Jun 27 '24 11:06 criemen

This acquired a conflict - removing my request to review so I don't get pinged for this daily, please add me back once you want to move forward with this.

criemen avatar Jul 17 '24 08:07 criemen