codeql-coding-standards icon indicating copy to clipboard operation
codeql-coding-standards copied to clipboard

`A20-8-5`-`A20-8-6`: Cannot create a smart pointer with `nullptr` value

Open nbusser-sr opened this issue 1 year ago • 1 comments

Affected rules

  • A20-8-5: cpp/autosar/make-unique-not-used-to-construct-object-owned-by-unique-ptr

Rule A20-8-5 (required, implementation, automated) std::make_unique shall be used to construct objects owned by std::unique_ptr.

  • A20-8-6: cpp/autosar/make-shared-not-used-to-construct-object-owned-by-shared-ptr

Rule A20-8-6 (required, implementation, automated) std::make_shared shall be used to construct objects owned by std::shared_ptr.

Description

A20-8-5 triggers when initializing an unique_ptr to nullptr.
A20-8-6 triggers when initializing an shared_ptr to nullptr.

Initializing a smart pointer with a nullptr value can be however necessary in some specific cases.

Example

std::unique_ptr<bool> uniquePtr{nullptr}; // Triggers A20-8-5
std::shared_ptr<bool> sharedPtr{nullptr}; // Triggers A20-8-6

nbusser-sr avatar Sep 30 '24 02:09 nbusser-sr

It should be straight forward to exclude nullptr from these queries. Thanks for the report!

lcartey avatar Oct 23 '24 22:10 lcartey