ccql icon indicating copy to clipboard operation
ccql copied to clipboard

Branch Protections Audit - 2022-10-05T18-41-55-524

Open repo-auditing-bot[bot] opened this issue 3 years ago • 0 comments

Action Items

This repo has been audited as a production component. Please respond in 4 weeks.

This repo was found missing required branch protections:

{
  "dismiss_stale_pr_reviews": {
    "error_message": "__required_pull_request_reviews.dismiss_stale_reviews__ Expected dismissal of stale PR approvals, found false.",
    "expected": true,
    "actual": false
  },
  "minumum_approving_reviewers": {
    "error_message": "__required_pull_request_reviews.required_approving_review_count__ Expected minumum 1, found undefined.",
    "expected": "> 1",
    "actual": "undefined"
  },
  "enforce_admins": {
    "error_message": "__enforce_admins__ Admins should not be allowed to bypass protections.",
    "expected": true,
    "actual": false
  }
}

If this audit is incorrect, or this repo does not need the outlined branch protections please file for an exception here.

  • NOTE, dismiss_stale_pr_reviews is not yet mandatory for this repository, but will be in 4 weeks.

What is this, and why am I just now finding out about this?

See this engineering discussion for more information.

repo-auditing-bot[bot] avatar Oct 05 '22 18:10 repo-auditing-bot[bot]