actions-learning-pathway icon indicating copy to clipboard operation
actions-learning-pathway copied to clipboard

Test step of build-test-deploy.yml is failing

Open bhilaire1a opened this issue 1 year ago • 5 comments

While doing the tutorial i noticed that the test workflow is failing because it is interactive by design.

 How would you like to configure ESLint? https://nextjs.org/docs/basic-features/eslint
25l❯  Strict (recommended)
   Base
 ⚠ If you set up ESLint yourself, we recommend adding the Next.js ESLint plugin. See https://nextjs.org/docs/basic-features/eslint#migrating-existing-config
   Cancel
Error: Process completed with exit code 1.

The ESLINT needs some configuration to be run. It works if you add the following

.eslintrc.json

{
  "extends": "next",
  "rules": {
    "react/no-unescaped-entities": "off"
  }
}

Another fix would be to actual fix the linter finding

./pages/index.js
20:9  Error: `'` can be escaped with `'`, `‘`, `'`, `’`.  react/no-unescaped-entities

bhilaire1a avatar Nov 30 '24 08:11 bhilaire1a

Came here to say the same thing. +1

krgvas avatar Dec 02 '24 11:12 krgvas

I have the same issue. Neither of the two suggestions fix the issue, however. Please advise.

tyrantdavis avatar Mar 04 '25 16:03 tyrantdavis

same here and tried all the steps advised above and even adding new config format eslint.config.js instead of .elintrc but nothing worked

rajnish-init avatar Mar 05 '25 09:03 rajnish-init

Hi, I created PR about this https://github.com/github/actions-learning-pathway/pull/14

DawidRyczko avatar Mar 14 '25 19:03 DawidRyczko

Hi, I created PR about this #14

As there was no merging into repository, i just follow the PR and see what files were updated, and I updated them accordingly in my repository.

Additionally, I have updated the latest version of node/actions in the build-test-deploy.yml (e.g. actions/checkout@v4, actions/setup-node@v4, node-version: '24.x', actions/configure-pages@v5, upload-pages-artifact@v3, actions/deploy-pages@v4)

P.S. Maybe this comment will be helpful in the future.

mipopescuU avatar Jun 18 '25 13:06 mipopescuU