github icon indicating copy to clipboard operation
github copied to clipboard

Commits, statuses, etc. after first page are not included in results

Open jplein opened this issue 7 years ago • 0 comments

Steps to reproduce:

  1. Find a commit with more than 30 statuses
  2. Write a script which instantiates a repo object and calls repo.listStatuses(sha), where sha is the commit from step 1
  3. Look at the list of results

Actual:

  • Only the first page of results is included
  • Looking at Repository.js, only a single HTTP request is being made:
    listStatuses(sha, cb) {
      return this._request('GET', `/repos/${this.__fullname}/commits/${sha}/statuses`, null, cb);
    }

Expected:

  • All are included, or something is implemented like the discussion in https://github.com/github-tools/github/issues/406

jplein avatar May 01 '18 23:05 jplein